From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 933711FF141 for ; Fri, 30 Jan 2026 09:14:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D87181723F; Fri, 30 Jan 2026 09:15:04 +0100 (CET) Message-ID: Date: Fri, 30 Jan 2026 09:15:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pbs-devel] [PATCH proxmox] lang: Remove offsetof macro To: Proxmox Backup Server development discussion , Maximiliano Sandoval References: <20260126141215.401447-1-m.sandoval@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260126141215.401447-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769760831971 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5PWACAGNU5BICIFWNNNDNQQ5GKSX6WGO X-Message-ID-Hash: 5PWACAGNU5BICIFWNNNDNQQ5GKSX6WGO X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/26/26 3:11 PM, Maximiliano Sandoval wrote: > With rust 1.90 this will crash while running cargo test with > > $ RUST_BACKTRACE=1 cargo test > > null pointer dereference occurred > stack backtrace: > 0: __rustc::rust_begin_unwind > at /usr/src/rustc-1.90.0/library/std/src/panicking.rs:697:5 > 1: core::panicking::panic_nounwind_fmt::runtime > at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:117:22 > 2: core::panicking::panic_nounwind_fmt > at /usr/src/rustc-1.90.0/library/core/src/intrinsics/mod.rs:2367:9 > 3: core::panicking::panic_null_pointer_dereference > at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:311:5 > 4: rust_out::main::_doctest_main_proxmox_lang_src_lib_rs_71_0 > 5: rust_out::main > 6: core::ops::function::FnOnce::call_once > > Note that the deref_nullptr lint is going to be denied by default on 1.93. > > Signed-off-by: Maximiliano Sandoval > --- > > As far as my greeping was able to tell, there should be no other users than the > docstring. Could not find any remaining users in our codebase as well, and since this macro has been deprecated since June 2024 according to the debian changelog, any remaining users should have already been moved to `std::mem::offset_of!` replacement anyways. Therefore consider: Acked-by: Christian Ebner