From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 3B14E1FF15C
	for <inbox@lore.proxmox.com>; Wed,  7 Aug 2024 17:24:10 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 655F39A86;
	Wed,  7 Aug 2024 17:24:18 +0200 (CEST)
Date: Wed, 7 Aug 2024 17:24:14 +0200
From: Christoph Heiss <c.heiss@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Message-ID: <erow4bvu5bufvkubwtdel26olzr34vzv4evdkfgj34zfxtjsag@oc7ldwkc3bf6>
References: <20240716134514.1656795-1-c.heiss@proxmox.com>
 <20240716134514.1656795-11-c.heiss@proxmox.com>
 <7f5d7334-d6a8-4447-87a8-6c4400071544@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <7f5d7334-d6a8-4447-87a8-6c4400071544@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.023 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [mod.rs]
Subject: Re: [pbs-devel] [PATCH proxmox-backup 10/14] config: use new
 dedicated PAM and PBS realm types
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

Thanks for the review!

On Wed, Aug 07, 2024 at 11:24:19AM GMT, Lukas Wagner wrote:
>
> On  2024-07-16 15:45, Christoph Heiss wrote:
> > diff --git a/src/config/mod.rs b/src/config/mod.rs
> > index 324fabca..3931eee9 100644
> > --- a/src/config/mod.rs
> > +++ b/src/config/mod.rs
> > [..]
> > +pub fn update_default_realms() -> Result<(), Error> {
> > [..]
> > +    if !pbs_config::domains::exists(&domains, "pbs") {
> > +        domains.set_data(
> > +            "pbs",
> > +            "pbs",
> > +            PbsRealmConfig {
> > +                realm: "pbs".to_owned(),
> > +                comment: Some("Proxmox Backup authentication server".to_owned()),
> > +                default: None,
> > +            },
> > +        )?;
> > +    }
>
> Just wondering, would it be a good idea to encode these defaults as
> the `Default::default()` impl for these two types? What do you think?

Yep, sounds good to me, TBH. I'll change that in v2.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel