From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 2FBE91FF15F
for <inbox@lore.proxmox.com>; Mon, 16 Dec 2024 14:01:52 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A3B0AC68F;
Mon, 16 Dec 2024 14:02:01 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tuxis.nl; s=mail;
h=from:reply-to:subject:date:message-id:to:cc:mime-version:content-type:
in-reply-to:references;
bh=bOGirJvtkYm57XKabdJbVSNHWt9NeYN9hzQyJA3y/rs=;
b=PuHdGfllcdrBzTbTRe346zW0K2QsXOSfHEWtIhj8lPLmj/5lIJm57ulCyMScjDs+PLai9vJD1V2IU
Q5PkuEsSD3vMhdjZSOB/xjB8XMiWP5Sts7Oia1EselBj2ikxrLpL0jyrwL1cJyM1LAOgQWx0P2lmDf
VnVdqsmj63XuVNv7si/9GyLipp8Ao/uQX41c6SwJ+FT3boEr51ssOLd3Yd+JZiOyCWmDyETxisMnfj
FaD6n+4m4yo8yEdbm2johiTgiOQPiozS3liJ7yZDNh/QcNv4Pq1nlpSvyoUjrhDyTypNlbSCdB0NQT
IN41aHeRpS90eyh2kobgnowascEew4g==
X-Footer: dHV4aXMubmw=
From: "Mark Schouten" <mark@tuxis.nl>
To: "Shannon Sterz" <s.sterz@proxmox.com>
Date: Mon, 16 Dec 2024 13:01:21 +0000
Message-Id: <emcc81564b-c295-40ee-9ae3-ff6834df3fe1@93f95f61.com>
In-Reply-To: <D6D3QC6Y5H4S.1QHYHPHXK6RVR@proxmox.com>
References: <ema6032dba-8585-4377-bec1-11a37159087c@192dede7.com>
<D6D024F1JMI5.QDFXDKCQMUCJ@proxmox.com>
<embeb48874-d400-4e69-ae0f-2cc56a39d592@93f95f61.com>
<D6D3QC6Y5H4S.1QHYHPHXK6RVR@proxmox.com>
User-Agent: eM_Client/10.1.4828.0
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.016 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain DMARC_PASS -0.1 DMARC pass policy
HTML_MESSAGE 0.001 HTML included in message
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] Authentication performance
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Mark Schouten <mark@tuxis.nl>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Content-Type: multipart/mixed; boundary="===============3589692068443614667=="
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
--===============3589692068443614667==
Content-Type: multipart/alternative;
boundary="------=_MB5BED59C5-E0E4-46A1-A1DF-8458DCBCFE54"
--------=_MB5BED59C5-E0E4-46A1-A1DF-8458DCBCFE54
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Hi,
>Sure, just be aware that you have to manually delete the key before
>restarting the PBS. Upgrading alone won't affect the key. Ideally you'd
>test this before rolling it out, if you can
Yes, we will keep that in mind.
>
>Possible, yes, that would depend on your configuration. Are all of these
>datastores defined with a backing device? Because if not, than this
>should be fairly fast (as in, this should not actually touch the disks).
>If they are, then yes this could be slow as each store would trigger at
>least 2 stat calls afaict.
They are all ZFS based, so not sure if that helps.
>In any case, it should be fine to move the `mount_status` check after
>the `if allowed || allow_id` check from what i can tell. Not sure why
>we'd need to check the mount_status for a datastore we won't include in
>the resulsts anyway. Same goes for parsing the store config imo. Send a
>patch for that [1].
>
>[1]: https://lore.proxmox.com/pbs-devel/20241216115044.208595-1-s.sterz@pr=
oxmox.com/T/#u
This might help, at least. Thanks!
So looking further into this, I noticed an average of ~ 70 calls per=20
second on:
/api2/json/admin/datastore/.+/status
I think that is `pub async fn status()` in that same file, right?=20
Nothing much to tune there.
Thanks again, I will keep you posted on the progress after our=20
maintenance window.
=E2=80=94
Mark Schouten
CTO, Tuxis B.V.
+31 318 200208 / mark@tuxis.nl
--------=_MB5BED59C5-E0E4-46A1-A1DF-8458DCBCFE54
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable
<html><head>
<style id=3D"css_styles" type=3D"text/css"><!--blockquote.cite { margin-lef=
t: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-le=
ft: 1px solid #cccccc }
blockquote.cite2 {margin-left: 5px; margin-right: 0px; padding-left: 10px;=
padding-right:0px; border-left: 1px solid #cccccc; margin-top: 3px; padding=
-top: 0px; }
a img { border: 0px; }
table { border-collapse: collapse; }
li[style=3D'text-align: center;'], li[style=3D'text-align: center; '], li[s=
tyle=3D'text-align: right;'], li[style=3D'text-align: right; '] { list-sty=
le-position: inside;}
body { font-family: Helvetica; font-size: 9pt; }
.quote { margin-left: 1em; margin-right: 1em; border-left: 5px #ebebeb soli=
d; padding-left: 0.3em; }
a.em-mention[href] { text-decoration: none; color: inherit; border-radius:=
3px; padding-left: 2px; padding-right: 2px; background-color: #e2e2e2; }
--></style></head>
<body style=3D"overflow-wrap: break-word; -webkit-nbsp-mode: space; line-br=
eak: after-white-space;"><div>Hi,</div><div><br /></div><div id=3D"x8ab9425=
d752e430" class=3D"plain"><blockquote cite=3D"D6D3QC6Y5H4S.1QHYHPHXK6RVR@pr=
oxmox.com" type=3D"cite" class=3D"cite2">
<div class=3D"plain_line">Sure, just be aware that you have to manually del=
ete the key before</div>
<div class=3D"plain_line">restarting the PBS. Upgrading alone won't affect=
the key. Ideally you'd</div>
<div class=3D"plain_line">test this before rolling it out, if you can</div>=
</blockquote><span><div id=3D"x8ab9425d752e430" class=3D"plain"><span><br /=
></span></div>Yes, we will keep that in mind.</span></div><div id=3D"x8ab94=
25d752e430" class=3D"plain"><blockquote cite=3D"D6D3QC6Y5H4S.1QHYHPHXK6RVR@=
proxmox.com" type=3D"cite" class=3D"cite2"><div class=3D"plain_line">=C2=A0=
</div>
<div class=3D"plain_line">Possible, yes, that would depend on your configur=
ation. Are all of these</div>
<div class=3D"plain_line">datastores defined with a backing device? Because =
if not, than this</div>
<div class=3D"plain_line">should be fairly fast (as in, this should not act=
ually touch the disks).</div>
<div class=3D"plain_line">If they are, then yes this could be slow as each=
store would trigger at</div>
<div class=3D"plain_line">least 2 stat calls afaict.</div></blockquote><spa=
n><div id=3D"x8ab9425d752e430" class=3D"plain"><span>They are all ZFS based=
, so not sure if that helps.</span></div><div id=3D"x8ab9425d752e430" class=
=3D"plain"><br /></div></span><blockquote cite=3D"D6D3QC6Y5H4S.1QHYHPHXK6RV=
R@proxmox.com" type=3D"cite" class=3D"cite2">
<div class=3D"plain_line">In any case, it should be fine to move the `mount=
_status` check after</div>
<div class=3D"plain_line">the `if allowed || allow_id` check from what i ca=
n tell. Not sure why</div>
<div class=3D"plain_line">we'd need to check the mount_status for a datasto=
re we won't include in</div>
<div class=3D"plain_line">the resulsts anyway. Same goes for parsing the st=
ore config imo. Send a</div>
<div class=3D"plain_line">patch for that [1].</div>
<div class=3D"plain_line">=C2=A0</div>
<div class=3D"plain_line">[1]: <a href=3D"https://lore.proxmox.com/pbs-deve=
l/20241216115044.208595-1-s.sterz@proxmox.com/T/#u" class=3D"__cef_visited"=
>https://lore.proxmox.com/pbs-devel/20241216115044.208595-1-s.sterz@proxmox=
.com/T/#u</a></div></blockquote><span><div id=3D"x8ab9425d752e430" class=3D=
"plain"><span><br /></span></div>This might help, at least.=C2=A0</span>Tha=
nks!</div><div id=3D"x8ab9425d752e430" class=3D"plain"><span><br /></span><=
/div><div id=3D"x8ab9425d752e430" class=3D"plain"><span>So looking further=
into this, I noticed an average of ~ 70 calls per second on:</span></div><d=
iv id=3D"x8ab9425d752e430" class=3D"plain"><span>/api2/json/admin/datastore=
/.+/status=C2=A0</span></div><div id=3D"x8ab9425d752e430" class=3D"plain"><=
span><br /></span></div><div id=3D"x8ab9425d752e430" class=3D"plain">I thin=
k that is `pub async fn status()` in that same file, right? Nothing much to =
tune there.</div><div id=3D"x8ab9425d752e430" class=3D"plain"><br /></div>=
<div id=3D"x8ab9425d752e430" class=3D"plain">Thanks again, I will keep you=
posted on the progress after our maintenance window.</div><div id=3D"x8ab94=
25d752e430" class=3D"plain"><div><br /></div><div id=3D"signature_old" styl=
e=3D"clear:both"><div style=3D"margin: 0px; padding: 0px; box-sizing: conte=
nt-box;">=E2=80=94=C2=A0</div><div style=3D"margin: 0px; padding: 0px; box-=
sizing: content-box;">Mark Schouten</div><div style=3D"margin: 0px; padding=
: 0px; box-sizing: content-box;">CTO, Tuxis B.V.</div><div style=3D"margin: =
0px; padding: 0px; box-sizing: content-box;">+31 318 200208 /=C2=A0mark@tu=
xis.nl</div></div><br style=3D"clear:both" /></div><div id=3D"x8ab9425d752e=
430" class=3D"plain"><blockquote cite=3D"D6D3QC6Y5H4S.1QHYHPHXK6RVR@proxmox=
.com" type=3D"cite" class=3D"cite2">
</blockquote></div>
</body></html>
--------=_MB5BED59C5-E0E4-46A1-A1DF-8458DCBCFE54--
--===============3589692068443614667==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
--===============3589692068443614667==--