Hi,

>Sure, just be aware that you have to manually delete the key before
>restarting the PBS. Upgrading alone won't affect the key. Ideally you'd
>test this before rolling it out, if you can

Yes, we will keep that in mind.
>
>Possible, yes, that would depend on your configuration. Are all of these
>datastores defined with a backing device? Because if not, than this
>should be fairly fast (as in, this should not actually touch the disks).
>If they are, then yes this could be slow as each store would trigger at
>least 2 stat calls afaict.
They are all ZFS based, so not sure if that helps.

>In any case, it should be fine to move the `mount_status` check after
>the `if allowed || allow_id` check from what i can tell. Not sure why
>we'd need to check the mount_status for a datastore we won't include in
>the resulsts anyway. Same goes for parsing the store config imo. Send a
>patch for that [1].
>
>[1]: https://lore.proxmox.com/pbs-devel/20241216115044.208595-1-s.sterz@proxmox.com/T/#u

This might help, at least. Thanks!

So looking further into this, I noticed an average of ~ 70 calls per 
second on:
/api2/json/admin/datastore/.+/status

I think that is `pub async fn status()` in that same file, right? 
Nothing much to tune there.

Thanks again, I will keep you posted on the progress after our 
maintenance window.

—
Mark Schouten
CTO, Tuxis B.V.
+31 318 200208 / mark@tuxis.nl