From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D084E1FF133 for ; Mon, 11 May 2026 10:28:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 74CE5B0DC; Mon, 11 May 2026 10:28:15 +0200 (CEST) Message-ID: Date: Mon, 11 May 2026 10:27:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 proxmox-backup 2/3] client: pxar: consistently ignore vanished files and warn about them To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260506115016.171006-1-r.obkircher@proxmox.com> <20260506115016.171006-3-r.obkircher@proxmox.com> <0dc3289a-f214-4d3b-8138-47ff79a61878@proxmox.com> <0def9d7e-135a-4db4-a7f9-56d512b1c15f@proxmox.com> <4d21540f-f92b-48e1-a586-81a2d4412b05@proxmox.com> <89b54e4c-1f39-43d5-b3c2-6d03a6170c3d@proxmox.com> <8ef30f56-0786-4d46-b7be-e56d71a92f27@proxmox.com> <2d49c10e-10ec-4160-9405-c8fda9285c9c@proxmox.com> <04ffa1f8-fa3a-4751-928b-d542fc1c09bf@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <04ffa1f8-fa3a-4751-928b-d542fc1c09bf@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778487946412 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [create.rs,proxmox.com] Message-ID-Hash: 2MHKYKLCN5LCR5AREGMXUOOQT5UD555E X-Message-ID-Hash: 2MHKYKLCN5LCR5AREGMXUOOQT5UD555E X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 08.05.26 16:11, Christian Ebner wrote: > On 5/8/26 4:01 PM, Robert Obkircher wrote: >> >> On 08.05.26 15:24, Christian Ebner wrote: >>> [..] >>> >>> In that case could you include a patch to cleanup the (one) other >>> implicit context creation? >> >> Which one? I don't see another one > > I was referring to: > > https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-client/src/pxar/create.rs;h=d18021c4c57620897c8a1122f521365f913573e9;hb=HEAD#l709 > > > Should be > > diff --git a/pbs-client/src/pxar/create.rs > b/pbs-client/src/pxar/create.rs > index d18021c4c..fe3f851f2 100644 > --- a/pbs-client/src/pxar/create.rs > +++ b/pbs-client/src/pxar/create.rs > @@ -707,7 +707,7 @@ impl Archiver { >                      continue; >                  } >                  Err(err) => { > -                    return Err(err).with_context(|| format!("stat > failed on {full_path:?}")) > +                    return Err(err).context(format!("stat failed on > {full_path:?}")) >                  } >              }  This patch already deletes that line.