From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2DE361FF15F for <inbox@lore.proxmox.com>; Mon, 21 Oct 2024 16:16:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 285B936337; Mon, 21 Oct 2024 16:17:13 +0200 (CEST) Message-ID: <ef465b74-c124-4ac9-8f1a-b0315a44eebc@proxmox.com> Date: Mon, 21 Oct 2024 16:16:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20240812103139.288854-1-c.ebner@proxmox.com> <437691f3-d7f5-4ee4-8ada-250950621460@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner <c.ebner@proxmox.com> In-Reply-To: <437691f3-d7f5-4ee4-8ada-250950621460@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 00/10] fix catalog dump and shell for split pxar archives X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On 10/21/24 16:07, Thomas Lamprecht wrote: > Am 12/08/2024 um 12:31 schrieb Christian Ebner: >> Christian Ebner (10): >> client: tools: make tools module public >> client: pxar: move catalog lookup helper to pxar tools >> client: tools: move pxar root entry helper to pxar submodule > > no hard feelings but maybe do a s/sub// to avoid making it sound > like this is git submodule related (but I might just have to much > exposure to the git ones to be "triggered" by just reading submodule > ;-) Okay, will adapt this according to your suggestion. >> client: make helper to get remote pxar reader reusable >> client: tools: factor out entry path prefix helper >> client: tools: factor out pxar entry to dir entry mapping >> client: add helper to dump catalog from metadata archive >> client: catalog: fallback to metadata archives for catalog dump >> client: helper to mimic catalog find using metadata archive >> client: catalog shell: fallback to accessor for navigation >> >> pbs-client/src/catalog_shell.rs | 291 +++++++++++++++++++++------ >> pbs-client/src/pxar/extract.rs | 2 +- >> pbs-client/src/pxar/mod.rs | 4 +- >> pbs-client/src/pxar/tools.rs | 256 ++++++++++++++++++++++- >> pbs-client/src/tools/mod.rs | 120 ----------- >> pbs-datastore/src/catalog.rs | 40 ++++ >> proxmox-backup-client/src/catalog.rs | 65 +++++- >> proxmox-file-restore/src/main.rs | 38 +--- >> pxar-bin/src/main.rs | 4 +- >> src/api2/admin/datastore.rs | 2 +- >> src/api2/tape/restore.rs | 2 +- >> 11 files changed, 599 insertions(+), 225 deletions(-) >> > > Looks OK to me in general code wise, albeit I did not evaluate every > patch very closely, but considering that a spot check did not find > anything odd and this is all mostly internal and got already reviewed > by Fabian I'd be fine with applying it. > > That said, your S-o-b trailer seems to be missing from all patches. Oh, you are right, but only on path 2 and 9? At least in the mails for the other patches I do see them. But this will be fixed in the next version, thanks for noticing! > For the refactoring ones it might be also nice to have a short sentence > for why this is done, e.g. referencing the future use like "this will > be used to do XYZ in a future commit". Okay, will amend the commit messages accordingly. Thanks for looking at these patches! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel