From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 77140901E2 for ; Wed, 5 Oct 2022 17:01:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FB4F347F for ; Wed, 5 Oct 2022 17:01:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 5 Oct 2022 17:01:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 45048445C0 for ; Wed, 5 Oct 2022 17:01:08 +0200 (CEST) Message-ID: Date: Wed, 5 Oct 2022 17:01:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Matthias Heiserer References: <20220920132128.380765-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220920132128.380765-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pbs-devel] applied: [PATCH v3 proxmox-backup] prune-simulator: allow setting a custom date/time X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2022 15:01:10 -0000 Am 20/09/2022 um 15:21 schrieb Matthias Heiserer: > With this, the prune simulator will be more flexible, which might clear > up questions such as these: > https://forum.proxmox.com/threads/pbs-prune-simulator-monthly-backups.115081 > > In order to have the configuration window not take up too much space, > I added another column and moved the border to the left. > > Signed-off-by: Matthias Heiserer > --- > Thanks to fiona for the many suggestions! > > CHANGES FROM v2: > use getDate (gives day of month) instead of getDay (day of week) > change instead of select, and check that input is valid > use Y-m-d in date selector to stay consistent with rest of page > include backup happening at selected time in simulation > slightly reworded commit message > > CHANGES FROM v1: > squash patches > wider column so no fields are cut off > smaller year/time labels > use viewmodel instead of `const NOW` > improve patch title > 24h (hh:mm) format for time > > .../prune-simulator/prune-simulator_source.js | 151 +++++++++++++----- > 1 file changed, 109 insertions(+), 42 deletions(-) > > applied, with Fiona's T-b and R-b tags, thanks! I reworked the layout of the whole simulation options panel in a few follow ups though, not really related directly to your patch, it just made me retake a closer look on the whole thing. Please holler if something broke.