From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9DF621FF16B for ; Thu, 17 Oct 2024 16:39:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B6A2C1292D; Thu, 17 Oct 2024 16:40:23 +0200 (CEST) Message-ID: Date: Thu, 17 Oct 2024 16:40:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20241011093355.218198-1-c.ebner@proxmox.com> <41eeb7b4-36ca-4983-85a1-cba26e6e686b@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <41eeb7b4-36ca-4983-85a1-cba26e6e686b@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 10/17/24 15:16, Thomas Lamprecht wrote: > applied this one, thanks! > > FYI: I found a bug within the Display code, months got printed with the > "m" unit, which is the unit for minutes. Besides fixing that I also made > it print "m" for minutes now to have more consistent unit variants (all > single letter) see the commit message for more details. > > I also added a basic module documentation to convey what the format is and > where it comes from and some basic unit tests, could be surely expanded > though. Great! So should we maybe start to switch over time duration output in the backup client logs to `TimeSpan`s display output? There are a few places where purely seconds are used. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel