From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B233565B59 for <pbs-devel@lists.proxmox.com>; Fri, 24 Jul 2020 09:36:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A07172F2DB for <pbs-devel@lists.proxmox.com>; Fri, 24 Jul 2020 09:35:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 33ABE2F2CD for <pbs-devel@lists.proxmox.com>; Fri, 24 Jul 2020 09:35:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E7CF5432ED; Fri, 24 Jul 2020 09:35:41 +0200 (CEST) To: Dietmar Maurer <dietmar@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20200723132013.22398-1-d.csapak@proxmox.com> <20200723132013.22398-2-d.csapak@proxmox.com> <513336870.482.1595575767098@webmail.proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> Message-ID: <ebc0b021-4a8d-7ad1-5cf6-7dc2190a94d9@proxmox.com> Date: Fri, 24 Jul 2020 09:35:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Thunderbird/79.0 MIME-Version: 1.0 In-Reply-To: <513336870.482.1595575767098@webmail.proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.861 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.344 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 2/2] server/state: add spawn_internal_task and use it for websockets X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 24 Jul 2020 07:36:12 -0000 On 7/24/20 9:29 AM, Dietmar Maurer wrote: >> is a helper to spawn an internal tokio task without it showing up >> in the task list > > Can't we use a normal worker task? > we could, but as i wrote in the mail, we'd either have * 2 visible WorkerTasks per terminal connection (one for the process, one for the websocket) -> this would be confusing for users.. * would have to make some workertasks invisible somehow (no upid? how to keep track of it then) -> much work for little gain? * we would have to refactor the whole terminal handling with termproxy, so that in only gets started during the websocket connection -> this is a non-trivial refactoring and would also have to be done on pve/pmg since they all share some code (at least the gui, which also has to be aware of some of this) so i think a small wrapper around tokio::spawn is not so bad