From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4CD687150D for ; Thu, 8 Apr 2021 08:19:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 41F3616863 for ; Thu, 8 Apr 2021 08:19:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D0B8D16856 for ; Thu, 8 Apr 2021 08:19:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 92A0E41F8D for ; Thu, 8 Apr 2021 08:19:10 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Reply-To: Proxmox Backup Server development discussion References: <20210329112537.17261-1-d.csapak@proxmox.com> Message-ID: Date: Thu, 8 Apr 2021 08:19:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210329112537.17261-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.169 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [values.store] Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 06:19:11 -0000 any comment? On 3/29/21 1:25 PM, Dominik Csapak wrote: > we have to delete the 'mapping' variable in any case since it's not > a valid api parameter > > Signed-off-by: Dominik Csapak > --- > www/tape/window/TapeRestore.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js > index a9deb745..d33080e4 100644 > --- a/www/tape/window/TapeRestore.js > +++ b/www/tape/window/TapeRestore.js > @@ -30,8 +30,8 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', { > > if (values.mapping) { > datastores.push(values.mapping); > - delete values.mapping; > } > + delete values.mapping; > > values.store = datastores.join(','); > >