From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 191BB1FF0E0 for ; Fri, 24 Jul 2026 00:00:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 70E132148A; Fri, 24 Jul 2026 00:00:36 +0200 (CEST) Message-ID: Date: Fri, 24 Jul 2026 00:00:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples To: Arthur Bied-Charreton , pbs-devel@lists.proxmox.com References: <20260723114548.319543-1-a.bied-charreton@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260723114548.319543-1-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784843971438 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HRJ36ADZKZ3W7GKUX37YSF3OZ22ZGIM4 X-Message-ID-Hash: HRJ36ADZKZ3W7GKUX37YSF3OZ22ZGIM4 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 23.07.26 um 13:45 schrieb Arthur Bied-Charreton: > The calendar matcher examples showed weekday ranges as start-end. The > correct syntax is start..end - these example configs do not parse. > > Update the examples to the correct a..b range syntax. > > Signed-off-by: Arthur Bied-Charreton > --- > docs/notifications.rst | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/docs/notifications.rst b/docs/notifications.rst > index 440c700a4..7d6517dd7 100644 > --- a/docs/notifications.rst > +++ b/docs/notifications.rst > @@ -217,8 +217,8 @@ Examples: > > * ``match-calendar 8-12`` Shouldn't above also change? or is that hours? These examples here would IMO do very well with actually explaining what each means, it's not exactly clear as it stands. A reference to the calendar events appendix at _calendar-event-scheduling would already help a lot and might we warranted either way, if this here is really using that format. > * ``match-calendar 8:00-15:30`` > -* ``match-calendar mon-fri 9:00-17:00`` FWIW; systemd-analyze calendar "mon-fri" works, but it does normalize it to mon..fri > -* ``match-calendar sun,tue-wed,fri 9-17`` > +* ``match-calendar mon..fri 9:00-17:00`` > +* ``match-calendar sun,tue..wed,fri 9-17`` > > Field Matching Rules > ^^^^^^^^^^^^^^^^^^^^ > @@ -417,4 +417,3 @@ Counter Threshold Description and Usage > ``s3-download`` Amount of bytes downloaded from the S3 endpoint, > independent of request method. > ==================== ========================================================== > - extra line removal, but fine as clean-up to tag along I guess.