From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 755851FF139 for ; Tue, 10 Feb 2026 09:42:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6706A18E8B; Tue, 10 Feb 2026 09:43:36 +0100 (CET) Message-ID: Date: Tue, 10 Feb 2026 09:43:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new' To: Proxmox Backup Server development discussion , Hannes Laimer References: <20260120113351.22921-1-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260120113351.22921-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770712928771 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KNYJSUSAKF26LW4ECQIC4SCSHILE3APT X-Message-ID-Hash: KNYJSUSAKF26LW4ECQIC4SCSHILE3APT X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/20/26 12:33 PM, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/api2/backup/environment.rs | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs > index bd9c5211..3c624b18 100644 > --- a/src/api2/backup/environment.rs > +++ b/src/api2/backup/environment.rs > @@ -799,10 +799,13 @@ impl BackupEnvironment { > false, > move |worker| { > worker.log_message("Automatically verifying newly added snapshot"); > - > - // FIXME: update once per-datastore read/verify settings > - // are available to not use default amount of threads here > - let verify_worker = VerifyWorker::new(worker.clone(), datastore, None, None)?; > + let thread_settings = datastore.thread_settings().clone(); > + let verify_worker = VerifyWorker::new( > + worker.clone(), > + datastore, > + thread_settings.verify_job_read_threads, > + thread_settings.verify_job_verify_threads, > + )?; > if !verify_worker.verify_backup_dir_with_lock( > &backup_dir, > worker.upid().clone(), I don't think this is necessary. VerifyWorker::new() already reads the datastore's verify thread settings if no custom (per-worker) values are passed in as parameters and falls back to the global defaults if none are set for the datastore. So the only thing to be done is drop the outdated FIXME comment and maybe improve the logging of the parameters being used if non-default, including which setting has been applied (global, datastore, job/cli invokation).