From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 928B464026 for ; Tue, 1 Mar 2022 09:53:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 908AA1D776 for ; Tue, 1 Mar 2022 09:53:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 292611D76B for ; Tue, 1 Mar 2022 09:53:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F36B6462AE for ; Tue, 1 Mar 2022 09:53:02 +0100 (CET) Message-ID: Date: Tue, 1 Mar 2022 09:53:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak , Dietmar Maurer References: <814473879.3457.1645802718067@webmail.proxmox.com> From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] pbs-datastore: use ConfigVersionCache for datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 08:53:03 -0000 On 28.02.22 07:51, Dominik Csapak wrote: > On 2/25/22 16:25, Dietmar Maurer wrote: >>> but on the other hand, we now basically create a new datastore object >>> every minute >> >> And you think this is a problem (why)? > > it seems unnecessary, and if it was not a problem, why didn't we do it before? > we already read/parsed the config anyway.... > > i assumed that there was a good reason not to construct a new object > every time, but i did not find it > Yeah I also do not get this, especially as there's zero info about "why" and the benefits in the commit message - that's more important than describing the diff that is attached to the commit anyway (not that this cannot help but focus should be on the former). Any benchmarking, timing assumptions or other things done? As more and more complex code should have /some/ arguing in favor of it sent along..