From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D1FD79DA27 for ; Fri, 24 Nov 2023 14:00:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AED3BF684 for ; Fri, 24 Nov 2023 13:59:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Nov 2023 13:59:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6DDA243BDD for ; Fri, 24 Nov 2023 13:59:56 +0100 (CET) Message-ID: Date: Fri, 24 Nov 2023 13:59:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Max Carrara References: <20231121100846.216207-1-m.carrara@proxmox.com> From: Lukas Wagner In-Reply-To: <20231121100846.216207-1-m.carrara@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v4 proxmox, proxmox-backup 0/3] Add support for HTTP to HTTPS redirection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2023 13:00:27 -0000 On 11/21/23 11:08, Max Carrara wrote: > This patch series adds support for redirecting HTTP requests to HTTPS. This is > done by peeking into the incoming TCP stream's buffer in order to check whether > the client initiates a TLS handshake or not. > > Secure and insecure connections are then sent along separate channels, allowing > them to be handled by different `hyper::Server`s (if so desired). > > Finally, `proxmox-backup-proxy` is adapted correspondingly, making it a little > more convenient to access PBS via its web interface. Gave this another test on the latest master, seems to work quite nicely. Code also looks good to me. Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner -- - Lukas