From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BC8C26B071 for ; Mon, 25 Jan 2021 16:13:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B209DCDB5 for ; Mon, 25 Jan 2021 16:13:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 45F5DCDA7 for ; Mon, 25 Jan 2021 16:13:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0C71F460E9 for ; Mon, 25 Jan 2021 16:13:07 +0100 (CET) To: pbs-devel@lists.proxmox.com References: <20210119133323.1420136-1-o.bektas@proxmox.com> From: Dominik Csapak Message-ID: Date: Mon, 25 Jan 2021 16:13:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210119133323.1420136-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.264 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: add missing uri encoding in user edit and view X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 15:13:07 -0000 LGTM Reviewed-by: Dominik Csapak On 1/19/21 2:33 PM, Oguz Bektas wrote: > userid parameter needs to be properly encoded when shown on the browser > > Signed-off-by: Oguz Bektas > --- > www/config/UserView.js | 2 ++ > www/window/UserEdit.js | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/www/config/UserView.js b/www/config/UserView.js > index 4645737a..ae313776 100644 > --- a/www/config/UserView.js > +++ b/www/config/UserView.js > @@ -139,6 +139,8 @@ Ext.define('PBS.config.UserView', { > xtype: 'proxmoxStdRemoveButton', > baseurl: '/access/users/', > enableFn: (rec) => rec.data.userid !== 'root@pam', > + getUrl: (rec) => > + `/access/users/${encodeURIComponent(rec.getId())}`, > callback: 'reload', > }, > '-', > diff --git a/www/window/UserEdit.js b/www/window/UserEdit.js > index aaae835f..06ec5377 100644 > --- a/www/window/UserEdit.js > +++ b/www/window/UserEdit.js > @@ -20,7 +20,7 @@ Ext.define('PBS.window.UserEdit', { > var baseurl = '/api2/extjs/access/users'; > > me.isCreate = !userid; > - me.url = userid ? baseurl + '/' + userid : baseurl; > + me.url = userid ? baseurl + '/' + encodeURIComponent(userid) : baseurl; > me.method = userid ? 'PUT' : 'POST'; > me.autoLoad = !!userid; > >