From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 16EA16F70C
 for <pbs-devel@lists.proxmox.com>; Mon, 30 Aug 2021 15:31:27 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 0A1791BCD7
 for <pbs-devel@lists.proxmox.com>; Mon, 30 Aug 2021 15:31:27 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 35EA01BCC6
 for <pbs-devel@lists.proxmox.com>; Mon, 30 Aug 2021 15:31:23 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 046DE44236
 for <pbs-devel@lists.proxmox.com>; Mon, 30 Aug 2021 15:31:23 +0200 (CEST)
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
References: <20210830083009.1853983-1-d.csapak@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <e6358777-514b-0e17-77e3-a2ae531181a3@proxmox.com>
Date: Mon, 30 Aug 2021 15:31:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210830083009.1853983-1-d.csapak@proxmox.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.328 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] applied: Re: [PATCH proxmox-backup] ui: fix order of
 prune keep reasons
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 30 Aug 2021 13:31:27 -0000

Am 8/30/21 um 10:30 AM schrieb Dominik Csapak:
> two things wrong with the old code:
>  * the sort function wants -1, 0 and 1 as a return value for a<b, a==b and a>b
>    respectively, not a bool (which a < b returns)
>  * we have to sort the newest backups first, since the first reason is
>    'keep-last'. until now, we sorted the oldest backup first, resulting
>    in the older backups getting the 'keep-last' reason
> 
> reported by a user in the forum:
> https://forum.proxmox.com/threads/prune-ui-and-prune-schedule-simulator-dont-match.94944/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/datastore/Prune.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

I'd maybe went for an arrow function here, mostly to match the sorting in the prune-simulator,
but really does not matters mucht, if at all, so:

applied, thanks!