From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 73BD869C22 for ; Wed, 15 Sep 2021 11:28:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 620B316E27 for ; Wed, 15 Sep 2021 11:28:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6451216E16 for ; Wed, 15 Sep 2021 11:28:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 30B0944888 for ; Wed, 15 Sep 2021 11:28:14 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210913141829.2171301-1-d.csapak@proxmox.com> From: Hannes Laimer Message-ID: Date: Wed, 15 Sep 2021 11:28:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210913141829.2171301-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.969 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.rs, format.rs, mod.rs, tasks.rs, datastore.rs, proxmox-backup-proxy.rs, pbs-shell.rs, sync.rs, pull.rs, user.rs, verify.rs, directory.rs] Subject: Re: [pbs-devel] [PATCH proxmox/proxmox-backup v2] add 'pbs-shell' tool X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 09:28:45 -0000 After testing everything seems to work as expected. One thing I noticed is that for create, delete, get and set the api-path parameter is called 'api-path', for ls and usage it is called 'path'. I know why this is, but it kind of gave the feeling of 'path' and 'api-path' being different things, even though they're not. However, it probably won't be a problem since the description is pretty clear. Am 13.09.21 um 16:18 schrieb Dominik Csapak: > this series adds the tool 'pbs-shell', similar to 'pvesh' and 'pmgsh' > this tool is intended mainly for debugging, but can be useful for > api calls not exposed via the client/manager. > > proxmox (and the dependency in proxmox-backup) need to be bumped > > proxmox-backup patches 3-6 are not strictly necessary, but improve > the api so that the 'ls' command works better > (there are still some api paths to be fixed) > > patch 7 is als not strictly necessary, but changes some workers > to print to stdout on the cli > > changes from v1: > * rebase on master > * rename 'path' parameter to 'api-path' since it clashed with some > api calls that had a 'path variable' > * better handle workers: > we must always wait for the local workers and do not need to > print their logs, since most workers print to stdout if the > rpcenv type is CLI. Also catch Ctrl+C and try to abort the worker > > proxmox: > > Dominik Csapak (1): > proxmox: generate_usage_str: don't require static lifetimes > > proxmox/src/api/cli/format.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > proxmox-backup: > > Dominik Csapak (7): > server: refactor abort_local_worker > add 'pbs-shell' utility > api2: add missing token list match_all property > api2: disks/directory: refactor BASE_MOUNT_DIR > api2: disks/directory: add 'name' property to directory mount listing > api2: nodes: add missing node list api call > api2: make some workers log on CLI > > Makefile | 2 + > debian/pbs-shell.bc | 3 + > debian/proxmox-backup-server.bash-completion | 1 + > debian/proxmox-backup-server.install | 3 + > docs/Makefile | 8 + > docs/pbs-shell/description.rst | 3 + > docs/pbs-shell/man1.rst | 40 ++ > src/api2/access/user.rs | 35 +- > src/api2/admin/datastore.rs | 4 +- > src/api2/admin/sync.rs | 6 +- > src/api2/admin/verify.rs | 5 +- > src/api2/config/datastore.rs | 5 +- > src/api2/mod.rs | 4 +- > src/api2/node/disks/directory.rs | 15 +- > src/api2/node/mod.rs | 12 +- > src/api2/node/tasks.rs | 2 +- > src/api2/pull.rs | 3 +- > src/api2/tape/backup.rs | 7 +- > src/bin/pbs-shell.rs | 528 +++++++++++++++++++ > src/bin/proxmox-backup-proxy.rs | 4 +- > src/server/verify_job.rs | 3 +- > src/server/worker_task.rs | 12 +- > zsh-completions/_pbs-shell | 13 + > 23 files changed, 688 insertions(+), 30 deletions(-) > create mode 100644 debian/pbs-shell.bc > create mode 100644 docs/pbs-shell/description.rst > create mode 100644 docs/pbs-shell/man1.rst > create mode 100644 src/bin/pbs-shell.rs > create mode 100644 zsh-completions/_pbs-shell >