From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7A9631FF173 for ; Thu, 1 Aug 2024 14:44:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F94234D45; Thu, 1 Aug 2024 14:44:52 +0200 (CEST) Message-ID: Date: Thu, 1 Aug 2024 14:44:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Dominik Csapak References: <20240723100448.1571064-1-d.csapak@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240723100448.1571064-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5622: backup client: properly handle rate/burst parameters X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/23/24 12:04, Dominik Csapak wrote: > the rate and burst parameters are integers, so the mapping from value > with `.as_str()` will always return `None` effectively never > applying any rate limit at all. > > To fix it, just map from u64 to HumanByte. > > Signed-off-by: Dominik Csapak > --- Did some tests on this and while the rate limit gets applied, the burst value does not seem to be honored for my case. Am I misinterpreting the burst parameter or is there still an underlying issue? Here is what was tested: - Monitor network throughput to localhost by running `tcpsubnet-bpfcc 127.0.0.1/32` as well as `iftop` (got only low additional traffic noise without invoking the proxmox-backup-client). - Before each proxmox-backup-client invocation, the chunks and snapshots were deleted from the datastore to have similar conditions. - Backup using proxmox-backup-client to local datastore via localhost by running `proxmox-backup-client backup usr.pxar:/usr --rate=100000`, rate limit is now honored as expected! - `proxmox-backup-client backup usr.pxar:/usr --rate=100000 --burst=1000000000000`, expected to reach much higher initial burst throughput because of the huge bucket size, but rate is limited to the same rate as above already from the beginning. - Without rate limit, much higher rates can be reached, so that is not the limiting factor. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel