From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 869FF6A3D4 for ; Thu, 16 Sep 2021 12:16:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78BD123CA1 for ; Thu, 16 Sep 2021 12:16:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0087323C93 for ; Thu, 16 Sep 2021 12:16:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BF97D448E0 for ; Thu, 16 Sep 2021 12:16:25 +0200 (CEST) To: Dominik Csapak , pbs-devel@lists.proxmox.com References: <20210906105755.2651203-1-d.csapak@proxmox.com> <20210906105755.2651203-9-d.csapak@proxmox.com> <1508b04a-597b-9744-5e52-16a5c7c6af41@proxmox.com> <35e351ba-b338-dee7-545a-14ad1a487305@proxmox.com> From: Fabian Ebner Message-ID: Date: Thu, 16 Sep 2021 12:16:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <35e351ba-b338-dee7-545a-14ad1a487305@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.181 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.698 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 08/12] api2/admin/datastore: add get/set_protection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 10:16:26 -0000 Am 13.09.21 um 10:34 schrieb Dominik Csapak: > On 9/10/21 14:43, Fabian Ebner wrote: >> Am 06.09.21 um 12:57 schrieb Dominik Csapak: >>> for gettin/setting the protected flag for snapshots (akin to notes) >>> >> >> For notes, there is a 'show' command, but not for protected. Is there >> an other way to query the current protection of a single snapshot via >> proxmox-backup-client? >> >> I'm working on bug #3307, which is the same feature for PVE and for >> integration with the PBS plugin it would be nicer to query only the >> single snapshot. Or should I list the whole group and extract the info >> from there instead? >> > > well, i did not think we would need a 'show' command yet for a single > snapshot, but if you'll need it, i can either add it later > or in a v2 (if the series needs some changes) > > the api already contains the 'get' method anyway > Using the API instead of the client also makes distinguishing between "not supported" (i.e. 404 status code) and some other error easy. To do the same with proxmox-backup-client, it would be necessary to match the error message, but that would require refactoring run_client_cmd (in PBSPlugin.pm) AFAICT. Anyways, during testing I noticed that the GET call does not fail if the requested snapshot doesn't even exist.