From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 367B41FF18C
	for <inbox@lore.proxmox.com>; Tue,  8 Apr 2025 14:58:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id A8B451D30E;
	Tue,  8 Apr 2025 14:58:46 +0200 (CEST)
Date: Tue, 8 Apr 2025 14:58:43 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <dhuywqe42lqae2twugmnzabtxokladjwjn2hqummlw5vdd5nxx@imeit6ai7msu>
Mail-Followup-To: Thomas Lamprecht <t.lamprecht@proxmox.com>, 
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20241210155344.357910-1-g.goller@proxmox.com>
 <e0cfec76-5149-4d3d-80be-b96ae633e1ee@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <e0cfec76-5149-4d3d-80be-b96ae633e1ee@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.021 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] restrict consent-banner
 text length
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On 08.04.2025 13:08, Thomas Lamprecht wrote:
>Am 10.12.24 um 16:53 schrieb Gabriel Goller:
>> Add a maxLength in of 63*1024 in the frontend. We allow a max body
>> size of 64*1204 in the api and to allow some other properties to
>> coexist, reserve 1024 characters. In the backend we set the limit to
>> 128000 (128kB), which is the same as in pve.
>
>I reduced it in PVE a bit again; might also make sense to increase the
>max POST size to 512 KiB just like in PVE, the rust based HTTP server
>should handle these sizes without a sweat if the perl one can do that.

I'll send a patch soon with a limit of 64kB on both frontend and api.
The increasing of the max body size is IMO better in a future patch as
that will need some testing.



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel