From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 28BCA74E76
 for <pbs-devel@lists.proxmox.com>; Fri,  4 Jun 2021 11:04:00 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 124D61AD2E
 for <pbs-devel@lists.proxmox.com>; Fri,  4 Jun 2021 11:03:30 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 9F4931AD22
 for <pbs-devel@lists.proxmox.com>; Fri,  4 Jun 2021 11:03:25 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6C3C745964
 for <pbs-devel@lists.proxmox.com>; Fri,  4 Jun 2021 11:03:25 +0200 (CEST)
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
 =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= <f.gruenbichler@proxmox.com>
References: <20210604071625.4811-1-d.csapak@proxmox.com>
 <1622794517.ypqwqri9n2.astroid@nora.none>
From: Dietmar Maurer <dietmar@proxmox.com>
Message-ID: <debe42a1-a782-5ad3-5948-af1d8b482475@proxmox.com>
Date: Fri, 4 Jun 2021 11:03:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <1622794517.ypqwqri9n2.astroid@nora.none>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.500 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.603 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup] client/pull: log snapshots
 that are skipped because of time
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2021 09:04:00 -0000


On 6/4/21 10:21 AM, Fabian Grünbichler wrote:
>
>> @@ -495,6 +496,11 @@ pub async fn pull_group(
>>   
>>           if let Some(last_sync_time) = last_sync {
>>               if last_sync_time > backup_time {
>> +                task_log!(
>> +                    worker,
>> +                    "skipping snapshot {} - older than last sync",
>> +                    snapshot
>> +                );
> adding this would mean that sync logs would grow and grow and grow over
> time..
>
> maybe a single:
>
> skipped 32 remote snapshots (2021-MM-DDTHH:MM::SSZ..2021-MM-DDTHH:MM::SSZ) older than newest local snapshot.
>
> it would mean only adding a single line to the output, but contains
> almost all the information?
>
I would also prefer a single log line.