From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0C90C1FF15C for ; Wed, 7 Aug 2024 21:20:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 689C2B6CE; Wed, 7 Aug 2024 21:20:56 +0200 (CEST) Message-ID: Date: Wed, 7 Aug 2024 21:20:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Dominik Csapak References: <20240723100448.1571064-1-d.csapak@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20240723100448.1571064-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5622: backup client: properly handle rate/burst parameters X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 23/07/2024 12:04, Dominik Csapak wrote: > the rate and burst parameters are integers, so the mapping from value > with `.as_str()` will always return `None` effectively never > applying any rate limit at all. > > To fix it, just map from u64 to HumanByte. > > Signed-off-by: Dominik Csapak > --- > > Alternatively, we could introduce a new string schema to parse into > HumanByte, if that's preferred. (Did not do it that way, because this > fix was way faster for me and is also OK in my opinion). I mean, tbh. it seems like this was the original intention, i.e. that one can also pass HumanByte here, which would be pretty convenient. FWIW, this was u64 back when added and there's a commit that changes this in a (buggy) way to the as_str, when HumanByte got introduced: 2d5287fb ("use RateLimitConfig for HttpClient and pull") Sadly the comment message of this and the previous ones are basically non-existent, but I faintly remember that Dietmar and I talked about this back then, and I'm pretty sure that my stance back then is as now: I find it odd that the API and config can have this written in HumanByte form but not on the CLI, where it'd be actually the most useful place; as the API is either accessed through web UI, where one can transform this from a human readable form to bytes or through a automation system, which normally have ways to allow X*1024 or the like calculations. So I'd rather go towards a HuamnByte based schema, albeit as the TRAFFIC_CONTROL_RATE_SCHEMA and TRAFFIC_CONTROL_BURST_SCHEMA are only used in the client CLI code anyway I'd actually drop them from pbs-api-types as they are obviously confusing (not used in the actual API) and either declare a ClientRateLimitConfig struct there (that is then flattened in the client backup schema definition) or just have something directly in the client code. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel