From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A03A271133 for ; Mon, 28 Jun 2021 09:28:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9204F283C9 for ; Mon, 28 Jun 2021 09:28:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1B409283BA for ; Mon, 28 Jun 2021 09:28:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D2029443C3 for ; Mon, 28 Jun 2021 09:28:12 +0200 (CEST) Message-ID: Date: Mon, 28 Jun 2021 09:28:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Aaron Lauterer References: <20210624093206.739285-1-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210624093206.739285-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.500 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.765 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] report: add disk/by-id and disk/by-path info X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 07:28:13 -0000 On 24.06.21 11:32, Aaron Lauterer wrote: > Globbing seems to not work, e.g. `ls -l /dev/disk/*`. Therefore calling > it two times for the id and path directories as those two are the most > useful in my experience when trying to infer things about the disks and > how they are connected. Globbing is a shell feature not one of core-utils commands or the like, the shell will always expand GLOBs first and the command will just see all files as arguments (that's why one can get "argument list to large" errors when using that, thus the existence of xargs, find's -exec and the like). > Signed-off-by: Aaron Lauterer > --- > src/server/report.rs | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/server/report.rs b/src/server/report.rs > index e89abbc5..73f73e52 100644 > --- a/src/server/report.rs > +++ b/src/server/report.rs > @@ -23,6 +23,8 @@ fn commands() -> Vec<(&'static str, Vec<&'static str>)> { > ("proxmox-backup-manager", vec!["versions", "--verbose"]), > ("df", vec!["-h"]), > ("lsblk", vec!["--ascii"]), > + ("ls", vec!["-l", "/dev/disk/by-id"]), > + ("ls", vec!["-l", "/dev/disk/by-path"]), Be the change^W GLOB you want to see, i.e., why not just expand yourself? ("ls", vec!["-l", "/dev/disk/by-id", "/dev/disk/by-path"]), > ("zpool", vec!["status"]), > ("zfs", vec!["list"]), > ("proxmox-backup-manager", vec!["subscription", "get"]), >