From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 691871FF172
for <inbox@lore.proxmox.com>; Tue, 15 Apr 2025 08:00:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E4F993EB7C;
Tue, 15 Apr 2025 08:00:53 +0200 (CEST)
Date: Tue, 15 Apr 2025 08:00:14 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Message-ID: <datzjrhadyorc5t4nazmuamy4qrhmzyik26rx77m2bv3odfkn6@wrlmiyy73jbh>
References: <20250414150929.639930-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250414150929.639930-1-m.sandoval@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.081 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [format.rs, proxmox.com]
Subject: [pbs-devel] applied: [PATCH proxmox] router: format: add newline at
the end
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
applied, but replaced the link with the usual inline commit reference,
since it's in the same repository
On Mon, Apr 14, 2025 at 05:09:29PM +0200, Maximiliano Sandoval wrote:
> Without this newline running commands with missing arguments, e.g.
> ```
> proxmox-backup-client backup
> ```
>
> will print their usage string without a newline at the end, which is
> costing me my sanity.
>
> As per [1], usage shouldn't contain trailing new lines and this in
> principle should not print double new lines.
>
> [1] https://git.proxmox.com/?p=proxmox.git;a=commit;h=d872eb9d7ebadbd8fcc9506eb2c5689632fa89bc
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> proxmox-router/src/cli/format.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-router/src/cli/format.rs b/proxmox-router/src/cli/format.rs
> index 95448aa9..e8ebe41f 100644
> --- a/proxmox-router/src/cli/format.rs
> +++ b/proxmox-router/src/cli/format.rs
> @@ -279,7 +279,7 @@ pub(crate) fn print_simple_usage_error_do<'cli>(
> &[],
> global_options_iter,
> );
> - eprint!("Error: {}\nUsage: {}", err_msg, usage);
> + eprintln!("Error: {}\nUsage: {}", err_msg, usage);
> }
>
> /// Print command usage for nested commands to ``stderr``.
> --
> 2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel