From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 182DC8EF6 for ; Tue, 7 Mar 2023 19:37:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E57D610310 for ; Tue, 7 Mar 2023 19:36:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 7 Mar 2023 19:36:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1E06D432AE for ; Tue, 7 Mar 2023 19:36:58 +0100 (CET) Message-ID: Date: Tue, 7 Mar 2023 19:36:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox Backup Server development discussion , Dominik Csapak References: <20230307141057.822269-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230307141057.822269-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jobstate.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2023 18:37:30 -0000 Am 07/03/2023 um 15:10 schrieb Dominik Csapak: > we try to create the job stat dir, not the rrdb one > > Signed-off-by: Dominik Csapak > --- > src/server/jobstate.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs > index 4f347ad1..74af992f 100644 > --- a/src/server/jobstate.rs > +++ b/src/server/jobstate.rs > @@ -88,7 +88,7 @@ pub fn create_jobstate_dir() -> Result<(), Error> { > .group(backup_user.gid); > > create_path(JOB_STATE_BASEDIR, Some(opts.clone()), Some(opts)) > - .map_err(|err: Error| format_err!("unable to create rrdb stat dir - {}", err))?; > + .map_err(|err: Error| format_err!("unable to create job stat dir - {}", err))?; no biggie, but in general feel free (or even encouraged) to inline format string variables when touching lines anyway, like {err} here. > > Ok(()) > }