From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B0A111FF13C for ; Thu, 05 Mar 2026 10:32:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 377E01FBFA; Thu, 5 Mar 2026 10:33:06 +0100 (CET) Message-ID: Date: Thu, 5 Mar 2026 10:32:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v2] datastore: don't skip empty namespaces on s3 refresh To: pbs-devel@lists.proxmox.com References: <20260305092032.29058-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260305092032.29058-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772703126081 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.988 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.018 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.703 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1.386 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: D5IJ7OPGIMM6GIVNBQ5IILWW4C5US3P4 X-Message-ID-Hash: D5IJ7OPGIMM6GIVNBQ5IILWW4C5US3P4 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-05 10:20, Hannes Laimer wrote: > Without this empty namespaces present on s3 won't be visible locally. > > Signed-off-by: Hannes Laimer > --- > v2, thanks @Fabian: > - don't duplicate dir creation, just move ns check to after dir > creation since it is identicaly for namespaces and other things > > pbs-datastore/src/datastore.rs | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs > index 7ad3d917..76b66f7d 100644 > --- a/pbs-datastore/src/datastore.rs > +++ b/pbs-datastore/src/datastore.rs > @@ -2534,11 +2534,6 @@ impl DataStore { > let object_path = object_path.strip_prefix(&store_prefix).with_context(|| { > format!("failed to strip store context prefix {store_prefix} for {object_key}") > })?; > - if object_path.ends_with(NAMESPACE_MARKER_FILENAME) { > - continue; > - } > - > - info!("Fetching object {object_path}"); > > let file_path = tmp_base.join(object_path); > if let Some(parent) = file_path.parent() { > @@ -2549,6 +2544,13 @@ impl DataStore { > )?; > } > > + if object_path.ends_with(NAMESPACE_MARKER_FILENAME) { > + info!("Created namespace {object_path}"); > + continue; > + } else { ^^ not wrong technically, but doesn't make much sense... :P sorry for the noise > + info!("Fetching object {object_path}"); > + } > + > let mut target_file = tokio::fs::OpenOptions::new() > .write(true) > .create(true)