From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D73BC0AD7 for ; Fri, 12 Jan 2024 10:28:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5EE511F0B7 for ; Fri, 12 Jan 2024 10:27:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Jan 2024 10:27:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1B9274536F for ; Fri, 12 Jan 2024 10:27:50 +0100 (CET) Message-ID: Date: Fri, 12 Jan 2024 10:27:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Dominik Csapak References: <20240111104036.3341854-1-d.csapak@proxmox.com> Content-Language: en-US From: Dietmar Maurer In-Reply-To: <20240111104036.3341854-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.358 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [inventory.rs, media.rs, drive.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup 0/5] improve duplicate label-text handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2024 09:28:21 -0000 applied On 1/11/24 11:40, Dominik Csapak wrote: > while most of the code assumes each label is unique in the inventory, > there is actually no safeguard against doing that. > > this can lead to confusion about which tape is > inserted/online/destroyed/vaulted/etc. > > so this series tries to improve the handling a bit by logging a warning > when encountering this, and also preventing new tapes being labeled with > an existing label > > also add the 'destroy' media function to the ui, so that users > can get more easily out of this situation > > Dominik Csapak (5): > tape: handle duplicate label-texts in inventory > api: tape: optinally accept uuid for destroy/move media > api: tape: don't allow duplicate media label-texts > ui: tape inventory: use uuid as id > ui: tape: add remove media button > > src/api2/tape/drive.rs | 79 +++++++++++++++++-------- > src/api2/tape/media.rs | 84 ++++++++++++++++++++++----- > src/tape/changer/online_status_map.rs | 26 +++++---- > src/tape/inventory.rs | 26 ++++++--- > www/Makefile | 1 + > www/tape/TapeInventory.js | 35 ++++++++++- > www/tape/window/MediaRemoveWindow.js | 66 +++++++++++++++++++++ > 7 files changed, 257 insertions(+), 60 deletions(-) > create mode 100644 www/tape/window/MediaRemoveWindow.js >