From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 97711B3C4 for ; Wed, 6 Apr 2022 16:41:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DE9B2C944 for ; Wed, 6 Apr 2022 16:41:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D9EAA2C939 for ; Wed, 6 Apr 2022 16:41:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB51541D51 for ; Wed, 6 Apr 2022 16:41:16 +0200 (CEST) Message-ID: Date: Wed, 6 Apr 2022 16:41:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Wolfgang Bumiller References: <20220406125112.37327-1-w.bumiller@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220406125112.37327-1-w.bumiller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] applied: [PATCH backup] use BufReader/Writer for Files passed to serde_json::from_reader/writer X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 14:41:17 -0000 On 06.04.22 14:51, Wolfgang Bumiller wrote: > As serde_json will otherwise read files 1 byte at a time. > Writing is a bit better, but syntacitcal elements (quotes, braces, > commas) still often show up as single write syscalls, so use BufWriter > there as well. > > Note that while we do store the file in the resulting objects, we do not > need to keep the buffered read/writers as we always `seek` to the > beginning on further file operations. > > Reported-by: Mark Schouten > Link: https://lists.proxmox.com/pipermail/pbs-devel/2022-April/004909.html > Signed-off-by: Wolfgang Bumiller > --- > @Mark: Hope the Reported-by tag is fine with you. > > proxmox-file-restore/src/block_driver_qemu.rs | 8 ++++---- > src/config/tfa.rs | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) > > applied, thanks!