From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EEA5370085 for ; Wed, 12 May 2021 21:20:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7649082D7 for ; Wed, 12 May 2021 21:20:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 42A8E82C1 for ; Wed, 12 May 2021 21:20:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0226A46556 for ; Wed, 12 May 2021 21:20:06 +0200 (CEST) Message-ID: Date: Wed, 12 May 2021 21:20:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210512142016.3476-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210512142016.3476-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.006 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [email.rs] Subject: [pbs-devel] applied: [PATCH proxmox v3] fix #3302: allow for more characters for email X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2021 19:20:38 -0000 On 12.05.21 16:20, Dominik Csapak wrote: > by removing the regex check here, that is responsibility of the caller > > this is ok since we pass the args directly and not via shell, so > command injection should not be possible yeah, if nothing is there to interpret injected commands then it really isn't possible, besides naturally some security issue in sendmail command parser or the like, but there's no future proofing against that.. ;-) > > Signed-off-by: Dominik Csapak > --- > tested command injection with emails like '--help' but this got sent > to '--help@myhostname' which got sent to 'root@myhostname' > > proxmox/src/tools/email.rs | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > applied, thanks!