From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E194D755F6 for ; Mon, 12 Jul 2021 18:20:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D6D30187F8 for ; Mon, 12 Jul 2021 18:20:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C2579187E7 for ; Mon, 12 Jul 2021 18:20:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 89B4241016 for ; Mon, 12 Jul 2021 18:20:38 +0200 (CEST) Message-ID: Date: Mon, 12 Jul 2021 18:20:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dietmar Maurer References: <20210712152338.249178-1-dietmar@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210712152338.249178-1-dietmar@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.465 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup] change tape drive lock path X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 16:20:39 -0000 On 12.07.21 17:23, Dietmar Maurer wrote: > New kernel has stricter checks on tmpfs with stick-bit on directories, so some > commands (i.e. proxmox-tape changer status) fails when executed as root, because > permission checks fails when locking the drive. > > This patch move the drive locks to /run/proxmox-backup/drive-lock. > > Note: This is incompatible to old locking mechmanism, so users may not > run tape backups during update (or running backup can fail). > --- > > Lock file permissions are still wrong if the user runs "proxmox-tape > changer status" as root and the lock file does not exist already. > > src/bin/proxmox-backup-api.rs | 1 + > src/tape/drive/mod.rs | 6 +++--- > src/tape/mod.rs | 18 ++++++++++++++++++ > 3 files changed, 22 insertions(+), 3 deletions(-) > > applied, thanks!