From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 85FEC91210 for ; Wed, 5 Oct 2022 19:37:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 61408531B for ; Wed, 5 Oct 2022 19:36:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 5 Oct 2022 19:36:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2079E43F21 for ; Wed, 5 Oct 2022 19:36:54 +0200 (CEST) Message-ID: Date: Wed, 5 Oct 2022 19:36:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Daniel Tschlatscher References: <20220429144732.92823-1-d.tschlatscher@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220429144732.92823-1-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup] Remove BackupFileDownloader.js file and Makefile entry X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2022 17:37:25 -0000 Am 29/04/2022 um 16:47 schrieb Daniel Tschlatscher: > While finishing up my previous patch series I stumbled upon this file > which is not referenced anywhere in the proxmox-backup repository nor > in any of the other repositories as far as I can tell (except in the > Makefile). > I searched far and wide for any occurences and tested the backup > explorer GUI without it, which still seems to work normally. > > Introduced in: 98425309b0106c9174505614525a9561d98c56d7 > References removed in: 3e395378bca5a844b2c820750cd57e4f2bfbacca > > Therefore I think this can be safely considered dead code and be > removed. It shall remain in the pve-devel archives forevermore anyway. > > Signed-off-by: Daniel Tschlatscher > --- > www/Makefile | 1 - > www/window/BackupFileDownloader.js | 146 ----------------------------- > 2 files changed, 147 deletions(-) > delete mode 100644 www/window/BackupFileDownloader.js > > applied, thanks!