From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CBACB6BA03 for ; Wed, 17 Mar 2021 20:39:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE8FFA3A0 for ; Wed, 17 Mar 2021 20:39:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A5BD8A391 for ; Wed, 17 Mar 2021 20:39:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E02A4277D for ; Wed, 17 Mar 2021 20:39:16 +0100 (CET) Message-ID: Date: Wed, 17 Mar 2021 20:39:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210317141918.24843-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210317141918.24843-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] server/email_notifications: do not double html escape X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 19:39:47 -0000 On 17.03.21 15:19, Dominik Csapak wrote: > the default escape handler is handlebars::html_escape, but this are > plain text emails and we manually escape them for the html part, so > set the default escape handler to 'no_escape' > > this avoids double html escape for the characters: '&"<>' in emails > > Signed-off-by: Dominik Csapak > --- > src/server/email_notifications.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/server/email_notifications.rs b/src/server/email_notifications.rs > index 70e13053..2acee538 100644 > --- a/src/server/email_notifications.rs > +++ b/src/server/email_notifications.rs > @@ -194,6 +194,7 @@ lazy_static::lazy_static!{ > let result: Result<(), TemplateError> = try_block!({ > > hb.set_strict_mode(true); > + hb.register_escape_fn(handlebars::no_escape); > > hb.register_helper("human-bytes", Box::new(handlebars_humam_bytes_helper)); > hb.register_helper("relative-percentage", Box::new(handlebars_relative_percentage_helper)); > for the record: This would need "server/email_notifications: do not panic on template registration" to be applied before, else it does not applies.