From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C116271332 for <pbs-devel@lists.proxmox.com>; Wed, 7 Apr 2021 18:00:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7DA312B42 for <pbs-devel@lists.proxmox.com>; Wed, 7 Apr 2021 18:00:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4D08112B32 for <pbs-devel@lists.proxmox.com>; Wed, 7 Apr 2021 18:00:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E74D459EB for <pbs-devel@lists.proxmox.com>; Wed, 7 Apr 2021 18:00:24 +0200 (CEST) Message-ID: <d47fef39-b4b2-ab4a-b9a5-197689f86547@proxmox.com> Date: Wed, 7 Apr 2021 18:00:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20210406090347.27579-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210406090347.27579-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.044 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rest.rs, tools.rs, compression.rs, zip.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v3 0/7] add compression to api/static files and zip X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 07 Apr 2021 16:00:55 -0000 On 06.04.21 11:03, Dominik Csapak wrote: > this series combines my two series about adding compression to > api calls/static as well as the zip deflate series > > changes from v2: > compression: > * comment out non 'Deflate' CompressionMethods to have better match arms > * use constants for 'magic' values > * (partially) parse accept-encoding qualifiers > zip: > * use DeflateEncoder instead of flate2 manually > * reorder patches so that the rustfmt patch comes first > > Dominik Csapak (7): > tools: add compression module > tools/compression: add DeflateEncoder and helpers > server/rest: add helper to extract compression headers > server/rest: compress api calls > server/rest: compress static files > tools/zip: run rustfmt > tools/zip: compress zips with deflate > > Cargo.toml | 1 + > src/server/rest.rs | 121 ++++++++++++++++---- > src/tools.rs | 1 + > src/tools/compression.rs | 232 +++++++++++++++++++++++++++++++++++++++ > src/tools/zip.rs | 133 +++++++++++++++------- > 5 files changed, 425 insertions(+), 63 deletions(-) > create mode 100644 src/tools/compression.rs > applied series, much thanks! As talked off-list I switched to Level::Default, while slightly slower on a "no network bottle neck" benchmark its actually smaller and faster in total on a real world benchmark with a throttled and latency spiked connection. (See followup commit message for detail and benchmark results)