From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E99BA98CC1 for ; Tue, 10 Oct 2023 11:13:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF8CC3047B for ; Tue, 10 Oct 2023 11:13:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 10 Oct 2023 11:13:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0C89244976 for ; Tue, 10 Oct 2023 11:13:07 +0200 (CEST) Message-ID: Date: Tue, 10 Oct 2023 11:13:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Markus Frank , Proxmox Backup Server development discussion References: <20231010063926.2248-1-m.frank@proxmox.com> <20231010063926.2248-2-m.frank@proxmox.com> <4e7d4f89-7dc6-4065-9089-0d74dc0d369f@proxmox.com> <7efa009d-a474-41db-b4bd-6e6cf78606c2@proxmox.com> From: Lukas Wagner In-Reply-To: <7efa009d-a474-41db-b4bd-6e6cf78606c2@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: add Remove button for DirectoryList X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2023 09:13:08 -0000 On 10/10/23 11:05, Markus Frank wrote: >>>       store: { >>>       fields: ['path', 'device', 'filesystem', 'options', 'unitfile'], >>>       proxy: { >> >> A high-level comment about the UI changes: >> In most places in our UI, we have a dedicated 'Remove' button right next >> to the 'Add/Create' and 'Edit' button: >> >> [Add] [Edit] [Remove] >> >> We don't need 'Edit' here, but why not just add the button right next >> to the 'Create: Directory' button? >> What's the rationale of  moving the remove button to a menu on the >> right-hand side? > Because I think it would be better if it looks the same in pve & pbs. > I think the reason for the menu in pve is that it is more difficult to > accidentally remove a directory. Ah yes, you are right, I didn't compare it to PVE. In that case it's probably fine and you can keep it that way. -- - Lukas