From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6C7FF1FF140 for ; Fri, 10 Apr 2026 17:44:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 533C5222BD; Fri, 10 Apr 2026 17:45:33 +0200 (CEST) Message-ID: Date: Fri, 10 Apr 2026 17:44:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: superseded: [PATCH v3 0/5] client: repository: add individual component parameters From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com References: <20260401225305.4069441-1-t.lamprecht@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20260401225305.4069441-1-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775835829222 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JLNVGHYFGY7LKJZNPRZ2ANNDVYHTMXEW X-Message-ID-Hash: JLNVGHYFGY7LKJZNPRZ2ANNDVYHTMXEW X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: superseded by https://lore.proxmox.com/pbs-devel/20260410154327.4133440-1-t.lamprecht@proxmox.com/T/#t On 02/04/2026 00:53, Thomas Lamprecht wrote: > Talked a bit with Wolfgang offlist and saw some duplication and > confusion that the v2 kept and partialyl introduced too. So this is the > resulting follow-up to v2 [1] (and v1 [0]). > > The compact repository URL format ([[auth-id@]server[:port]:]datastore) > can be cumbersome to work with when changing a single aspect of the > connection or when using API tokens. This series adds --server, --port, > --datastore, --auth-id, and --ns as separate CLI parameters alongside > the existing compound --repository URL. > > Changes since v2: > - Deduplicated the param resolution cascade into a shared helper, which > should hopefully also make the change slightly easier to follow. > - Split BackupRepositoryArgs into two: BackupRepositoryArgs (repo fields > only) and BackupTargetArgs (wraps repo args + ns). This avoids the > confusing ns: None pattern in the resolution code. > - small cleanups. > > Changes since v1: > - Split the single large commit into separate patches for struct + > logic, command migration, docs, and PBS_NAMESPACE > - CLI atom options now merge with PBS_* env vars per-field (CLI wins) > - Fixed error swallowing when combining --repository with atom options > - Fixed duplicate ns property in the restore command's #[api] block > - PBS_NAMESPACE env var support across all client binaries (bug #5340) > > [0] https://lore.proxmox.com/pbs-devel/20260323211400.2661765-1-t.lamprecht@proxmox.com/ > [1] https://lore.proxmox.com/pbs-devel/20260330182352.2346420-1-t.lamprecht@proxmox.com/ > > Thomas Lamprecht (5): > client: repository: add tests for BackupRepository parsing > client: repository: add individual component parameters > client: migrate commands to flattened repository args > docs: document repository component options and env vars > fix #5340: client: repository: add PBS_NAMESPACE environment variable > > docs/backup-client.rst | 64 +++++ > pbs-client/src/backup_repo.rs | 321 ++++++++++++++++++++++++- > pbs-client/src/tools/mod.rs | 279 ++++++++++++++++++--- > proxmox-backup-client/src/benchmark.rs | 8 +- > proxmox-backup-client/src/catalog.rs | 26 +- > proxmox-backup-client/src/group.rs | 14 +- > proxmox-backup-client/src/main.rs | 101 ++++---- > proxmox-backup-client/src/mount.rs | 17 +- > proxmox-backup-client/src/namespace.rs | 33 +-- > proxmox-backup-client/src/snapshot.rs | 84 ++----- > proxmox-backup-client/src/task.rs | 20 +- > proxmox-file-restore/src/main.rs | 43 ++-- > src/bin/proxmox_backup_debug/diff.rs | 23 +- > 13 files changed, 784 insertions(+), 249 deletions(-) >