From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 358C477F37 for ; Wed, 21 Jul 2021 17:02:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 28FB1171BF for ; Wed, 21 Jul 2021 17:02:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 272D8171B1 for ; Wed, 21 Jul 2021 17:02:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F226B41664 for ; Wed, 21 Jul 2021 17:02:01 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210721140451.1839470-1-d.csapak@proxmox.com> <20210721140451.1839470-2-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: Date: Wed, 21 Jul 2021 17:02:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210721140451.1839470-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.840 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup 2/4] tape: changer: sg_pt: add SCSI_VOLUME_TAG_LEN const X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 15:02:33 -0000 applied On 7/21/21 4:04 PM, Dominik Csapak wrote: > so that we do have less 'magic' constants without description > > Signed-off-by: Dominik Csapak > --- > src/tape/changer/sg_pt_changer.rs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/tape/changer/sg_pt_changer.rs b/src/tape/changer/sg_pt_changer.rs > index f4154ced..908311b0 100644 > --- a/src/tape/changer/sg_pt_changer.rs > +++ b/src/tape/changer/sg_pt_changer.rs > @@ -33,6 +33,7 @@ use crate::{ > }; > > const SCSI_CHANGER_DEFAULT_TIMEOUT: usize = 60*5; // 5 minutes > +const SCSI_VOLUME_TAG_LEN: usize = 36; > > /// Initialize element status (Inventory) > pub fn initialize_element_status(file: &mut F) -> Result<(), Error> { > @@ -509,7 +510,7 @@ impl SubHeader { > ) -> Result, Error> { > > if (self.flags & 128) != 0 { // has PVolTag > - let tmp = reader.read_exact_allocated(36)?; > + let tmp = reader.read_exact_allocated(SCSI_VOLUME_TAG_LEN)?; > if full { > let volume_tag = scsi_ascii_to_string(&tmp); > return Ok(Some(volume_tag)); > @@ -526,7 +527,7 @@ impl SubHeader { > ) -> Result, Error> { > > if (self.flags & 64) != 0 { // has AVolTag > - let _tmp = reader.read_exact_allocated(36)?; > + let _tmp = reader.read_exact_allocated(SCSI_VOLUME_TAG_LEN)?; > } > > Ok(None)