From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 978B562A62 for ; Tue, 27 Oct 2020 17:56:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85E6E19533 for ; Tue, 27 Oct 2020 17:55:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D953719527 for ; Tue, 27 Oct 2020 17:55:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9FCD145F6D for ; Tue, 27 Oct 2020 17:55:46 +0100 (CET) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20201027152011.7373-1-d.csapak@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Tue, 27 Oct 2020 17:55:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201027152011.7373-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.124 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [verify.rs, sync.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/8] improve datstore ux X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 16:56:21 -0000 On 27.10.20 16:20, Dominik Csapak wrote: > this series aims to improve the datastore ux by > * moving all datastore relevant settings/options/views into the > datastore tabpanel > * adding a 'Summary' panel with some important information > * improving tab selection between datastores/browser reloads/etc. >=20 > this needs my previous series: "improve and extend admin/datastore/stat= us api" > to work >=20 > some things are still to be improved, namely: > * multiline comments for datastores > * automatic ids for sync/verify jobs > * improved prune/gc panel (e.g. with status of last run) > * comments for backup snapshots >=20 > Dominik Csapak (8): > api/{verify,syncjobs}: add optional datastore parameter > ui: DataStoreContent: add 'Verify All' button > ui: add DataStorePruneAndGC panel and add it to datastore panel > ui: add DataStoreSummary and move Statistics into it > ui: move sync/verify jobs to the datastores > ui: NavigationTree: add 'Add Datastore' button below datastore list > ui: MainView/NavigationTree: improve tree selection handling > ui: DataStorePanel: save active tab statefully >=20 > src/api2/admin/sync.rs | 19 ++- > src/api2/admin/verify.rs | 19 ++- > www/DataStoreContent.js | 23 +++ > www/DataStoreNotes.js | 104 ++++++++++++ > www/DataStorePanel.js | 52 +++++- > www/DataStorePruneAndGC.js | 164 +++++++++++++++++++ > www/DataStoreStatistic.js | 104 ------------ > www/DataStoreSummary.js | 296 ++++++++++++++++++++++++++++++++++= > www/MainView.js | 70 ++++---- > www/Makefile | 5 +- > www/NavigationTree.js | 101 ++++++++---- > www/config/DataStoreConfig.js | 227 -------------------------- > www/config/SyncView.js | 14 +- > www/config/VerifyView.js | 20 ++- > www/window/DataStoreEdit.js | 147 +++++++++-------- > www/window/SyncJobEdit.js | 6 +- > www/window/VerifyJobEdit.js | 6 +- > 17 files changed, 898 insertions(+), 479 deletions(-) > create mode 100644 www/DataStoreNotes.js > create mode 100644 www/DataStorePruneAndGC.js > delete mode 100644 www/DataStoreStatistic.js > create mode 100644 www/DataStoreSummary.js > delete mode 100644 www/config/DataStoreConfig.js >=20 applied series, much thanks! FYI, pushed the following small patches on t= op: ui: datastore summary: clarify that it's a deduplication factor ui: datastore: used fixed-width icons for summary ui: datastore: change GC/Prune title and buttons a bit ui: datastore: add confirmation message to verify all Some possible additions and thoughts: * warning on summary if no GC, prune or verify job is configured (especia= lly verify should be an warning-triangle, the other could be "notice-exclamation-mark" le= vel) * The "Removed Bytes" in the summary is a bit strange to me, I'd rather d= rop it * make the backup count thing aligned like a table, with the Groups and S= napshots as column header, and maybe a "Total" row at the end with all summed up * not sure where we'd put the only recently added "verify_new" datastore = option, it could be possible to rename "Verify Jobs" to "Verification" and add a option pan= el over the jobs one, would only host that setting for now, though. * onlineHelp buttons for all panels and their edit dialogs please (@Dylan= , @Oguz, @all)