From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 950BAB719 for ; Thu, 7 Apr 2022 10:38:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 903DE2AA4 for ; Thu, 7 Apr 2022 10:37:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1C5C42A99 for ; Thu, 7 Apr 2022 10:37:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E736341A28 for ; Thu, 7 Apr 2022 10:37:40 +0200 (CEST) Message-ID: Date: Thu, 7 Apr 2022 10:37:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: pbs-devel@lists.proxmox.com References: <20220404095048.25443-1-h.laimer@proxmox.com> <20220404095048.25443-3-h.laimer@proxmox.com> From: Dominik Csapak In-Reply-To: <20220404095048.25443-3-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.582 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.873 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-widget-toolkit 2/2] DiskList: handle partition data from PBS backend X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 08:38:11 -0000 some nits inline: On 4/4/22 11:50, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/panel/DiskList.js | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js > index eb8b1a8..c1877ef 100644 > --- a/src/panel/DiskList.js > +++ b/src/panel/DiskList.js > @@ -169,8 +169,19 @@ Ext.define('Proxmox.DiskList', { > let data = item.data; > data.leaf = true; > data.expanded = true; > - data.children = []; > + data.children = data.partitions ? data.partitions : []; could be written as 'data.children = data.partitions ?? [];' > + for (let p of data.children) { > + p['disk-type'] = 'partition'; > + p.iconCls = 'fa fa-fw fa-hdd-o x-fa-tree'; > + p.parent = data.devpath; > + p.children = []; > + p.leaf = true; > + } > data.iconCls = 'fa fa-fw fa-hdd-o x-fa-tree'; > + if (data.children.length > 0) { > + data.leaf = false; > + } we already set it above to true and here potentially to false. better imho would be to not set it at the beginning and here doing a data.leaf = data.children.length === 0; so that we only set it once > + > if (!data.parent) { > disks[data.devpath] = data; > }