From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id D8B901FF0E6
	for <inbox@lore.proxmox.com>; Fri, 24 Jul 2026 08:48:34 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 75028214AE;
	Fri, 24 Jul 2026 08:48:34 +0200 (CEST)
Date: Fri, 24 Jul 2026 08:48:00 +0200
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [PATCH proxmox-perl-rs 24/29] notify: opt into 'legacy-matchers'
 feature in proxmox-notify
Message-ID: <cvcydk3ki4g4eb7wyzjthmum4opigrmjsld4ixsfojllode6r2@kof3wktaalwz>
References: <20260709115716.299836-1-l.wagner@proxmox.com>
 <20260709115716.299836-25-l.wagner@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260709115716.299836-25-l.wagner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1784875650970
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     1.026 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_LOW        -0.7 Sender listed at https://www.dnswl.org/,
 low trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: SXVPP6KKOK5UDKWI3BXBHN5TDEO2XQYW
X-Message-ID-Hash: SXVPP6KKOK5UDKWI3BXBHN5TDEO2XQYW
X-MailFrom: a.bied-charreton@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On Thu, Jul 09, 2026 at 01:57:11PM +0200, Lukas Wagner wrote:
> This allows us to continue to support the older 'match-*', 'mode' and
> 'invert-match' configuration keys in notifications.cfg.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  pve-rs/Cargo.toml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pve-rs/Cargo.toml b/pve-rs/Cargo.toml
> index 5ae9082..ab95f29 100644
> --- a/pve-rs/Cargo.toml
> +++ b/pve-rs/Cargo.toml
> @@ -39,7 +39,7 @@ proxmox-http = { version = "1.0.2", features = ["client-sync", "client-trait"] }
>  proxmox-http-error = "1"
>  proxmox-log = "1"
>  proxmox-network-types = "1.1.2"
> -proxmox-notify = { version = "1", features = ["pve-context"] }
> +proxmox-notify = { version = "1", features = ["pve-context", "legacy-matchers"] }
afaict this should also be added to pmg-rs. it currently does not
compile otherwise. 
>  proxmox-oci = "0.2.1"
>  proxmox-openid = "1.0.2"
>  proxmox-resource-scheduling = "2"
> -- 
> 2.47.3
> 
> 
> 
> 
>