From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BBB06B3A7 for ; Wed, 6 Apr 2022 15:08:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABC292B534 for ; Wed, 6 Apr 2022 15:08:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A915C2B529 for ; Wed, 6 Apr 2022 15:08:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E91B4590A for ; Wed, 6 Apr 2022 15:08:22 +0200 (CEST) Message-ID: Date: Wed, 6 Apr 2022 15:08:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Hannes Laimer References: <20220217171457.72206-1-h.laimer@proxmox.com> From: Dylan Whyte In-Reply-To: <20220217171457.72206-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.653 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.631 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v9 0/6] closes #3071: maintenance mode for datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 13:08:53 -0000 Hi, On 2/17/22 18:14, Hannes Laimer wrote: > Adds maintenance mode and tracking of active reading/writing operations. > The maintenance mode prevents the start of new operations if the type of > operation they would perform on the datastore would conflict with the > maintenance type that is currently set. This check is performed when > lookup_datastore is called. Tasks only call this function once at the > beginning, therefore updating the maintenance type cannot interfere with > already running tasks. > > active operations tracking: > Changed file layout to now also keep track of the pid+starttime and the > counts of operations that that pid started, like this it is possible to > not count operations that were started by a dead process, since they > are also not active anymore. Whenever the file is updated, also entries > of dead processes are removed. When the file is read, only entries of > active processes are counted. > > The UI shows a spinner with the count of conflictintg tasks (the tasks > that were started before the maintenance type was updated) next to it. > As soon as all conflicting tasks are finished a checkmark appears. > > Hannes Laimer (6): > api-types: add maintenance type > datastore: add check for maintenance in lookup > pbs-datastore: add active operations tracking > api: make maintenance_type updatable > api: add get_active_operations endpoint > ui: add option to change the maintenance type > > debian/control | 6 +- > pbs-api-types/Cargo.toml | 2 +- > pbs-api-types/src/datastore.rs | 24 +++++- > pbs-api-types/src/lib.rs | 3 + > pbs-api-types/src/maintenance.rs | 78 +++++++++++++++++ > pbs-datastore/Cargo.toml | 1 + > pbs-datastore/src/datastore.rs | 121 +++++++++++++++++++-------- > pbs-datastore/src/lib.rs | 4 + > pbs-datastore/src/snapshot_reader.rs | 6 +- > pbs-datastore/src/task_tracking.rs | 110 ++++++++++++++++++++++++ > src/api2/admin/datastore.rs | 81 ++++++++++++------ > src/api2/backup/mod.rs | 4 +- > src/api2/config/datastore.rs | 5 ++ > src/api2/reader/mod.rs | 6 +- > src/api2/status.rs | 4 +- > src/api2/tape/backup.rs | 6 +- > src/api2/tape/restore.rs | 6 +- > src/bin/proxmox-backup-api.rs | 1 + > src/bin/proxmox-backup-proxy.rs | 4 +- > src/server/mod.rs | 16 +++- > src/server/prune_job.rs | 4 +- > src/server/pull.rs | 4 +- > src/server/verify_job.rs | 4 +- > www/Makefile | 1 + > www/Utils.js | 23 +++++ > www/datastore/OptionView.js | 30 +++++++ > www/window/MaintenanceOptions.js | 77 +++++++++++++++++ > 27 files changed, 540 insertions(+), 91 deletions(-) > create mode 100644 pbs-api-types/src/maintenance.rs > create mode 100644 pbs-datastore/src/task_tracking.rs > create mode 100644 www/window/MaintenanceOptions.js I just wanted to reply to this series, to get the ball rolling again. However, I can't say that I found much real issues with it on first glance, so I've just added some very minor suggestions. As a rebase is now required for it to apply, I haven't done any testing. I'd be happy to test once it's rebased though. regards, Dylan