From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0D2681FF186 for <inbox@lore.proxmox.com>; Fri, 2 Aug 2024 12:48:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 983E7AD94; Fri, 2 Aug 2024 12:48:31 +0200 (CEST) Message-ID: <cf4c39e9-87d2-41c2-80ef-a7373d91339d@proxmox.com> Date: Fri, 2 Aug 2024 12:47:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20240731093604.1315088-1-d.csapak@proxmox.com> <20240731093604.1315088-4-d.csapak@proxmox.com> <fa70b3f1-e7d0-4cd2-ad07-65a0cfa0f892@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <fa70b3f1-e7d0-4cd2-ad07-65a0cfa0f892@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [docs.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 3/4] datastore: data blob: increase compression throughput X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On 7/31/24 16:39, Thomas Lamprecht wrote: > Am 31/07/2024 um 11:36 schrieb Dominik Csapak: >> For now, we have to parse the error string for that, as `zstd` maps all >> errors as `io::ErrorKind::Other`. Until that gets changed, there is no >> other way to differentiate between different kind of errors. > > FWIW, you could also use the lower-level zstd_safe's compress2 [0] here, > compress_to_buffer is just a thin wrapper around that [1] anyway. Then you > could match the return value to see if it equals `70`, i.e., the value of > the ZSTD_error_dstSize_tooSmall [2] from the ZSTD_ErrorCode enum. > > I mean, naturally it would be much better if upstream provided a saner > interface or at least a binding for the enum, but IME such error codes > are quite stable if defined in this enum way, at least more stable than > strings, so might be a slightly better workaround. > > [0]: https://docs.rs/zstd-safe/latest/zstd_safe/struct.CCtx.html#method.compress2 > [1]: https://docs.rs/zstd/latest/src/zstd/bulk/compressor.rs.html#117-125 > [2]: https://github.com/facebook/zstd/blob/fdfb2aff39dc498372d8c9e5f2330b692fea9794/lib/zstd_errors.h#L88 sadly AFAICS this is currently not possible i tried this and instead of error 70 i got: '18446744073709551546' reading your [2] link, it also states: > * note 1 : this API shall be used with static linking only. > * dynamic linking is not yet officially supported. so i don't thinks this works, unless we'd link statically? so how do we want go forward with this? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel