From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4681265A98 for ; Wed, 4 Nov 2020 14:42:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 38FBFE4E7 for ; Wed, 4 Nov 2020 14:42:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C2691E4DD for ; Wed, 4 Nov 2020 14:42:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8083746022 for ; Wed, 4 Nov 2020 14:42:39 +0100 (CET) To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20201104131026.4017010-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Wed, 4 Nov 2020 14:42:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201104131026.4017010-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.118 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/4] www: don't default to hourly sync job schedule X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 13:42:40 -0000 (resend, as I forgot to keep the mailing list as recipient) On 04.11.20 14:10, Fabian Gr=C3=BCnbichler wrote: > this breaks editing disabled sync jobs, and is also not consistent with= just means that we should only set it onCreate.. > the backend defaults. which is? FWICT, there's no default in the backend - I want one here, this can be easily edited and it's just better UX to avoid more decisions= which at this point may not be clear. > > Signed-off-by: Fabian Gr=C3=BCnbichler > --- > www/window/SyncJobEdit.js | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js > index c89b95d2..43338cab 100644 > --- a/www/window/SyncJobEdit.js > +++ b/www/window/SyncJobEdit.js > @@ -84,7 +84,6 @@ Ext.define('PBS.window.SyncJobEdit', { > fieldLabel: gettext('Schedule'), > xtype: 'pbsCalendarEvent', > name: 'schedule', > - value: 'hourly', > emptyText: gettext('none (disabled)'), > cbind: { > deleteEmpty: '{!isCreate}', >