From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BDB1A71CB7 for ; Fri, 21 May 2021 16:35:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AAABDFFDF for ; Fri, 21 May 2021 16:34:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 73257FFCE for ; Fri, 21 May 2021 16:34:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3E365439AA for ; Fri, 21 May 2021 16:34:52 +0200 (CEST) Message-ID: Date: Fri, 21 May 2021 16:34:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210521102022.26859-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210521102022.26859-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v4 0/5] ui: unify and improve tape restore window X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 14:35:23 -0000 On 21.05.21 12:20, Dominik Csapak wrote: > changes from v3 (sent as v2): > * use two panel layout for restore window ('what', 'where') > * rewrite using a controller > * add some small bugfixes for the snapshotGrid and datastore mapping > * remove reload after restore > > changes from v2: > * split patches in proper self-containted commits > * changed layout in restore window > datastore mapping grid is now on the right, other options on the left > * integrated the selection checkbox into the checkbox selection model of > the grid (removing a seperate field) > * integrated the filter textbox into the gridfilters plugin, to save space > (like we do in pves bulk action window) > the benefit of this is that we do not have to combine/split the > store:snapshots anymore besides when assembling the submitdata, > this makes the code a little nicer imho > applied series, thanks! There's an issue with restoring single groups/snapshots/datastores though, a early triggered change event tried to de-reference not yet available objects, resulting in an exception. Most of that was only for setting different label/emptyText and hiding some components depending if there was more than one datastore to restore, I could replaced that logic by using a viewModel relative easily, so I went for that. I also added a followup to change the datastore-map emptyText when a default datastore was selected, so that it's clear to the user that not no datastore but the default datastore is used. in anyway, the wizard makes this much nicer, especially when restoring multiple snapshots. But please split it out in it's own, slightly more general, component definition in a separate file - should be still easy now and makes it easier to move this to widget-toolkit and drop this and the PVE one (you naturally can do that now too, but probably a bit more work..)