From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB6FE88F5 for ; Mon, 25 Apr 2022 11:44:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B967D5F8D for ; Mon, 25 Apr 2022 11:44:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 420B05F82 for ; Mon, 25 Apr 2022 11:44:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1AABA428E5 for ; Mon, 25 Apr 2022 11:44:28 +0200 (CEST) Message-ID: Date: Mon, 25 Apr 2022 11:44:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stefan Sterz References: <20220412103423.3845322-1-s.sterz@proxmox.com> <20220412103423.3845322-6-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220412103423.3845322-6-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup v5 5/5] fix #3067: ui: add a separate notes view for longer markdown notes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 09:44:28 -0000 On 12.04.22 12:34, Stefan Sterz wrote: > since markdown notes might be rather long, this commit adds a tab > similar to pve's datacenter or node notes. requires a bump of the > widget toolkit in order to use the `pmxNotesView`. > > Signed-off-by: Stefan Sterz > --- > i chose the maxLength of a note in pbs to be 1022*64 because the > server allows at most 1024*64 bytes of form data per request, which > are distributed as follows: > > equal signs: 2 > the word "digest": 7 > digest: 64 > the word "description": 12 > description: 65451 > > so by setting the limit to 1024*64 some users might encounter an > error telling them that the message body was too large even though the > front-end said the description was fine. i wanted to approximate > the 1024*64 limit here as close as possible so i chose: > 65451 / 64 ~ 1022. > > note that afaict due to the way maxLength is implemented the frontend > might not report an error when it should. this is due to character > encodings and how javascript's string length property works. > > www/Makefile | 1 + > www/NavigationTree.js | 6 ++++++ > www/NodeNotes.js | 23 +++++++++++++++++++++++ > 3 files changed, 30 insertions(+) > create mode 100644 www/NodeNotes.js > > applied, thanks!