From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3C6711FF29F for ; Thu, 18 Jul 2024 14:13:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2DC3B077; Thu, 18 Jul 2024 14:13:49 +0200 (CEST) Message-ID: Date: Thu, 18 Jul 2024 14:13:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion , Christoph Heiss References: <20240712075449.238010-1-c.heiss@proxmox.com> <1626412400.1424.1721301545661@webmail.proxmox.com> <772481c8-3bb6-42c7-95ef-29074819f00c@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <772481c8-3bb6-42c7-95ef-29074819f00c@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v2] sys: file: use renameat2() from `nix` crate X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/18/24 14:03, Thomas Lamprecht wrote: > Am 18/07/2024 um 13:19 schrieb Christian Ebner: >> Partially my fault, as I overlooked in my suggestion that linkat() does not accept `AtFlags` in version 0.26.1 just yet [0]. >> The suggested replacement type is however already there, but the module namespace is incorrect in the patch. Should have been [1]. >> >> [0] https://docs.rs/nix/0.26.1/nix/unistd/fn.linkat.html >> [1] https://docs.rs/nix/0.26.1/nix/fcntl/struct.AtFlags.html >> > > The type is there, but isn't accepted by `nix::unistd::linkat`, nor is there > a variant of that method that would accept it in this version FWICS. No, there is not, this will not work with nix v0.26.1 as my suggestion was wrong. Just wanted to mention that I did overlook this when suggesting this to Christoph. So I guess it is best to apply v1 and only later on replace the type, when using nix version >= v0.28 Sorry if I caused noise, should have tested this myself before even replying to the v1 :( _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel