From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A2CC49ADD for ; Mon, 26 Jun 2023 14:25:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8C08B27FEE for ; Mon, 26 Jun 2023 14:24:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Jun 2023 14:24:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB95D44150 for ; Mon, 26 Jun 2023 14:24:40 +0200 (CEST) Message-ID: Date: Mon, 26 Jun 2023 14:24:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Lukas Wagner , Proxmox Backup Server development discussion References: <20230626093916.701659-1-s.sterz@proxmox.com> <20230626093916.701659-3-s.sterz@proxmox.com> <64613c59-ec49-ac47-3211-a29b1db02d70@proxmox.com> From: Stefan Sterz In-Reply-To: <64613c59-ec49-ac47-3211-a29b1db02d70@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.089 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox 2/4] ldap: add check_connection function X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2023 12:25:11 -0000 On 26.06.23 14:23, Lukas Wagner wrote: > Hello, > > On 6/26/23 11:39, Stefan Sterz wrote: >> +    /// Helper to check if a connection with the current >> configuration is possible. >> +    /// >> +    /// This performs a search with the current configuration. If the >> search succeeds `Ok(()) is >> +    /// returned, otherwise an `Error` is returned. >> +    pub async fn check_connection(&self) -> Result<(), Error> { > > The `proxmox-ldap` crate actually has some integration tests, running > tests against a > real LDAP server (glauth). For reference, take a look at > `tests/glauth.rs` and > `tests/run_integration_tests.sh`. They are ignored by default, since > they require the > `glauth` binary in your `PATH`. > > It would be cool if you could add some tests for this new function. Can > of course happen in a > followup patch! :) > > Ah thanks, yeah i'll look into it, but i wanted to get this out in time for the next release. the tests probably won't make it in time, hope that's alright.