From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CD7F81FF184 for ; Thu, 20 Nov 2025 16:08:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 37F65C4D9; Thu, 20 Nov 2025 16:08:57 +0100 (CET) Message-ID: Date: Thu, 20 Nov 2025 16:08:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Shannon Sterz References: <20251120145031.550340-1-s.hanreich@proxmox.com> <20251120145031.550340-2-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.725 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox 1/5] proxmox-upgrade-checks: fix meta package version check X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/20/25 4:03 PM, Shannon Sterz wrote: > ah thanks for catching this, i somehow missed this, i'll need to ping my > series finally switching pdm over to this crate again. anyhow, for now > this is fine, though i would appreciate this approach a bit more: > > ``` > if let Some(old_version) = meta_pkg.and_then(|m| m.old_version.as_ref()) { > let pkg_version = Regex::new(r"^(\d+)\.(\d+)[.-](\d+)")?; > let captures = pkg_version.captures(old_version); > ``` yeah, this seems indeed better - Idk why I always default to map over and_then in such cases :P _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel