From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id B1E381FF138
	for <inbox@lore.proxmox.com>; Mon, 29 Jun 2026 13:12:46 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 3C6982141C;
	Mon, 29 Jun 2026 13:12:46 +0200 (CEST)
Message-ID: <c73cb7db-1dd2-4186-ac13-f7bd2c94e7c5@proxmox.com>
Date: Mon, 29 Jun 2026 13:12:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 proxmox 1/2] proxmox-sys: avoid unnecessary conversion
 in replace_file
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
References: <20260617105000.232928-1-r.obkircher@proxmox.com>
 <20260617105000.232928-2-r.obkircher@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <20260617105000.232928-2-r.obkircher@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1782731550822
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.069 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: FUJTEKPVSATBANWCWZVRGX6W2O5SUYN6
X-Message-ID-Hash: FUJTEKPVSATBANWCWZVRGX6W2O5SUYN6
X-MailFrom: c.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On 6/17/26 12:49 PM, Robert Obkircher wrote:
> Since make_tmp_file already returns a File there is no need to convert
> to a raw file descriptor and back.
> 
> Fixes: 26c06df4 ("make_tmp_file: return File instead of Fd")
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>