From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D596E1FF13F for ; Thu, 12 Mar 2026 15:11:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9498D18789; Thu, 12 Mar 2026 15:11:37 +0100 (CET) Message-ID: Date: Thu, 12 Mar 2026 15:11:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v5 13/13] s3-client: implement request counter threshold and exceeding callback To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260311130823.724888-1-c.ebner@proxmox.com> <20260311130823.724888-14-c.ebner@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260311130823.724888-14-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773324626883 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XOUPO5UMNAS35WT3BYSFSZJRIDAI6X5T X-Message-ID-Hash: XOUPO5UMNAS35WT3BYSFSZJRIDAI6X5T X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-11 14:09, Christian Ebner wrote: > Allows to set the threshold values to trigger exceeding callbacks > for the s3 request counters. > The globally settable callback function is executed whenever one of > the request counters is exceeding it's set threshold value, but > only once when passing over the threshold. > > Signed-off-by: Christian Ebner > --- [..] > /// Returns upload traffic count. > @@ -109,13 +170,51 @@ impl RequestCounters { > /// > /// Returns the previously stored value. > pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 { > - self.download.0.fetch_add(count, ordering) > + let prev = self.download.0.fetch_add(count, ordering); > + let threshold = self.upload_threshold.0.load(Ordering::Acquire); small typo, should be `download_threshold` > + let downloaded = prev + count; > + if threshold > 0 && downloaded > threshold && prev <= threshold { > + let guard = SHARED_COUNTER_THRESHOLD_EXCEEDED_CALLBACK.read().unwrap(); > + if let Some(callback) = guard.as_ref() { > + callback("downloaded", threshold, downloaded); > + } > + } > + prev > } [..]