From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 53461CD96 for ; Tue, 19 Sep 2023 15:37:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3D108B31C for ; Tue, 19 Sep 2023 15:37:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Sep 2023 15:37:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3428B47FC6 for ; Tue, 19 Sep 2023 15:37:40 +0200 (CEST) Message-ID: Date: Tue, 19 Sep 2023 15:37:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Lukas Wagner To: Proxmox Backup Server development discussion , Hannes Laimer References: <20230915065457.352953-1-h.laimer@proxmox.com> Content-Language: de-AT, en-US In-Reply-To: <20230915065457.352953-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/23] add removable datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2023 13:37:44 -0000 On 9/15/23 08:54, Hannes Laimer wrote: > b404eea5 and e5863f7e are not strictly needed, but they made sense in > this context, so I kept them in this series. > Please refer to the commit message/patch number directly - there is no way to find out for me which commits are meant by that :) Gave these patches a try on the latest master, here is what I found: - Datastore add UI: Might make sense to restructure the dialog, the checkbox for 'removable datastore' influences UI elements that are before the checkbox - a user might have entered something to the datastore path field before toggling the checkbox. - I'm not sure if the USB icon is the best choice for a removable data store. it could be a hot plugged SATA disk, iSCSI, etc. - maybe change this to something more generic if possible? - UI: datastore summary page: underscore in `/mnt/removeable_datastore` is not rendered in my firefox (117.0.1) - Mounting/Unmounting does not seem to work properly for me, here is what I did: - New VM with PBS, latest updates - Attached second disk - Created ext4 partition - created new removabale datastore from GUI - unmount from CLI (promxox-backup-manager datastore unmount --store test) does not seem to have any effect - pressing on 'unmount' in the GUI seems to work (verified by `mount`), but the GUI still considers the datastore as mounted - the `mount` button remains disabled - a `promxox-backup-manager datastore mount --store test` on the CLI does not seem to have any effect - There is no way to prepare a disk for the use as a removable datastore from the UI alone. We can create a GPT partition table and create an ext4 partition on it (via 'Directory'), however this creates a mount point for the new partition, so it cannot be used any more when creating a datastore. Maybe creating the mount point could be optional? -- - Lukas